Page MenuHomePhabricator
Differential D3500

Various nits in the Qt code
ClosedPublic
Actions

Authored by deadalnix on Jul 1 2019, 16:00.

Details

Reviewers
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGcad612f796db: Various nits in the Qt code
rABCcad612f796db: Various nits in the Qt code
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
qtnits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6592
Build 11231: Bitcoin ABC Buildbot (legacy)
Build 11230: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 1 2019, 16:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2019, 16:00
teamcity added a comment.Jul 1 2019, 16:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 1 2019, 16:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6592: Diff 9858!Jul 1 2019, 16:03
Fabien accepted this revision.Jul 1 2019, 20:20
This revision is now accepted and ready to land.Jul 1 2019, 20:20
deadalnix updated this revision to Diff 9880.Jul 1 2019, 20:25

rebase

teamcity added a comment.Jul 1 2019, 20:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6605: Diff 9880.Jul 1 2019, 20:33
teamcity added a comment.Jul 1 2019, 20:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jul 1 2019, 20:37
Closed by commit rABCcad612f796db: Various nits in the Qt code (authored by deadalnix). · Explain WhyJul 1 2019, 21:57
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCcad612f796db: Various nits in the Qt code.
deadalnix added a commit: rSTAGINGcad612f796db: Various nits in the Qt code.Sep 19 2019, 00:50

Revision Contents
Changeset List

Diff 9858

View Options

src/qt/addressbookpage.h

Loading...
View Options

src/qt/addressbookpage.cpp

Loading...
View Options

src/qt/addresstablemodel.cpp

Loading...
View Options

src/qt/editaddressdialog.h

Loading...
View Options

src/qt/editaddressdialog.cpp

Loading...