Page MenuHomePhabricator
Differential D3509

Backport base58 tests from PR11167
ClosedPublic
Actions

Authored by deadalnix on Jul 1 2019, 21:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING563841135476: Backport base58 tests from PR11167
rABC563841135476: Backport base58 tests from PR11167
Summary

As per title.

https://github.com/bitcoin/bitcoin/pull/11167/commits/6565c5501cfe7755585fd72f6329eea4c5eb2bf1
https://github.com/bitcoin/bitcoin/pull/11167/commits/bd355b8db9ffaacaafd10eb14f6b74cf00d8fc06

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11167
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6650
Build 11347: Bitcoin ABC Buildbot (legacy)
Build 11346: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 1 2019, 21:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2019, 21:57
teamcity added a comment.Jul 1 2019, 21:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 1 2019, 22:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6609: Diff 9886.Jul 1 2019, 22:03
Fabien requested changes to this revision.Jul 2 2019, 06:53
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/base58_tests.cpp
16 ↗(On Diff #9886)

Revert

20 ↗(On Diff #9886)

Dito

206 ↗(On Diff #9886)

As you are looping over the various chains, I don't understand the added in mainnet ?

Edit: https://github.com/bitcoin/bitcoin/pull/11167#discussion_r140595269

209 ↗(On Diff #9886)

Dito

This revision now requires changes to proceed.Jul 2 2019, 06:53
deadalnix updated this revision to Diff 9951.Jul 3 2019, 13:02

Address comments

teamcity added a comment.Jul 3 2019, 13:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 3 2019, 13:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6650: Diff 9951.Jul 3 2019, 13:09
Fabien accepted this revision.Jul 3 2019, 14:17
This revision is now accepted and ready to land.Jul 3 2019, 14:17
Closed by commit rABC563841135476: Backport base58 tests from PR11167 (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyJul 3 2019, 14:19
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC563841135476: Backport base58 tests from PR11167.
deadalnix added a commit: rSTAGING563841135476: Backport base58 tests from PR11167.Sep 19 2019, 00:53

Revision Contents
Changeset List

PathSize
src/
test/
100 lines
data/
213 lines

Diff 9951

View Options

src/test/base58_tests.cpp

Loading...
View Options

src/test/data/base58_keys_valid.json

Loading...