Page MenuHomePhabricator
Feed Advanced Search

Feb 3 2019

florian updated the diff for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Included a unit test for IsWitnessProgram, a few other test cases for ALLOW_SEGWIT_RECOVERY and created a wrapper for IsWitnessProgram()

Feb 3 2019, 04:55
florian requested review of D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 3 2019, 03:37
florian updated the diff for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Removed unused parameters from IsWitnessProgram

Feb 3 2019, 02:47
florian retitled D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY from Add ALLOW_SEGWIT_RECOVERY to Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 3 2019, 02:32
florian planned changes to D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 3 2019, 02:26
florian updated the diff for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Refactored to be restrictive to segwit programs.

Feb 3 2019, 02:26
florian updated the summary of D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 3 2019, 02:24

Feb 2 2019

florian requested review of D2479: Add activation code for SEGWIT_RECOVERY.

You can try it by yourself in mainnet:

Feb 2 2019, 22:07
florian requested review of D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 2 2019, 22:04
florian added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 2 2019, 02:01
florian updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

Removed PreviousSpendableOutput() and changed to network_thread_start()

Feb 2 2019, 00:14
florian added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 2 2019, 00:06

Feb 1 2019

florian added a comment to D2479: Add activation code for SEGWIT_RECOVERY.

Did you notice bitcoind is still returning 'non-mandatory-script-verify-flag (Script did not clean its stack)' even though CLEANSTACK is mandatory right now? Should the recently activated flags be included in MANDATORY_SCRIPT_VERIFY_FLAGS, like you did previously?

Feb 1 2019, 22:54
florian added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 1 2019, 22:50
florian updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

Refactored next_block, removed useless test and included a test to verify whether the activation was latched during a reorg

Feb 1 2019, 22:50
Herald added a reviewer for D2479: Add activation code for SEGWIT_RECOVERY: Restricted Project.
Feb 1 2019, 17:36
florian added a comment to D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Oh I see. My original intention was to converge on the simplest solution (spec, implementation and verification-wise) that allowed the retrieval of segwit coins while keeping all the malleability gains from the cleanstack rule. This proposal was not specific to segwit so the requirement description (which I still need to write and create a PR on github) and verification are relatively simple. Is it really your wish to be this specific on segwit? All those segwit specific requirements (e.g: redeem script size between 4 and 42, starting with OP_0, ..., OP_16, etc) will have to go into the spec for the HF and, as you pointed out, will require a few extra tests.

Feb 1 2019, 02:05

Jan 31 2019

florian updated the diff for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Simplified the changes in VerifyScript

Jan 31 2019, 23:01
florian added inline comments to D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Jan 31 2019, 22:50
Herald added a reviewer for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY: Restricted Project.
Jan 31 2019, 20:54