- User Since
- Jun 8 2017, 18:12 (301 w, 6 d)
Aug 26 2018
All test green 👍
Mar 16 2018
Pushing local changes before traveling to SV
The blocks are fully rejected if they are bigger than a value. (TODO: discuss what max block size whould be ok for this check)
The EBP block's transactions are validated only when their chain have enough PoW to become the active one. (The CheckBlock function was split in two functions)
A basic RPC test was created to simulate an EBP activation using 2 nodes.
Mar 5 2018
Mar 2 2018
Sep 6 2017
Sep 5 2017
Code here: D522
Sep 1 2017
Function to validate the missing consensus rules on EC blocks: T100
The code is here D519
Aug 29 2017
Store the blocks: T98
Aug 28 2017
IsNotValid method created to group the excessive and invalid modes.
Added tests for the IsNotValid and IsExcessive functions.
Created new flag for blocks not valid, using the previous not valid block flag + the is excessive flag.
Mode Excessive moved to second position in the ValidationState to represent that the invalid mode is more restrictive.
Ban score when validating an excessive block modified to 10. (It may need to be lower)
I installed clang-format 3.8 and this changes are no longer needed.
Aug 25 2017
It's being coded here D484
Aug 23 2017
The first task is this: https://reviews.bitcoinabc.org/T94
Aug 22 2017
The autopep8 changes weren't in the master branch, i'll create a new diff with them
rebase to current master to get the autopep8 changes in the rpc-tests.py file
Aug 20 2017
Removed blocksize code. Moved block check to the globalconfig. Fixed index error in FindMostWorkChain.
Aug 15 2017
Removed BU code and saved not valid yet chain to be reevaluated.
TODO: fix bug with iterators, update policy values when a new chain is accepted, change variables names to something smaller.
Aug 10 2017
When I have the smaller diffs ready, I'll link them so the code can be reviewed easily. The smaller diff will have the tests and the hardcoded values will get their values from global variables.
Trying the bitcoin unlimited EC code.
There are many changes and not everything has its test. I'm going to separate this diff in 2 or 3 smaller diff (each one with their tests) so it can be reviewed.
Aug 8 2017
Aug 5 2017
It looks good, make check is green.
The test is passing with this changes
Jul 28 2017
Checking CTxMemPool's members to be empty
Jun 21 2017
Test renamed to mempool-accept-txn.py
Test name also was edited in the qa/pull-tester/rpc-tests.py file
Added missing end line at the end of the abc-p2p-fullblocktest.py file (that line was not copied when copy-pasted the original abc-p2p-fullblocktest.py code to revert the changes)
Reverted changes on abc-p2p-fullblocktest.py
Created new test named mempool_p2sh_txn.py derived from p2p-fullblocktest
The new test was added to the qa/pull-tester/rpc-tests.py
MAX_STANDARD_TX_SIGOPS was declared in the qa/rpc-tests/test-framework/cdefs.py file
Jun 20 2017
Jun 19 2017
The bitprim seeds are OK
Jun 16 2017
Using create_and_sign_transaction method to create the p2sh_tx
Removed b30 local variable
Using p2sh_tx variable instead of the first block transaction in the spend_p2sh_tx method
Jun 15 2017
Requested changes applied