Page MenuHomePhabricator

hanchon (Guillermo Paoletti)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2017, 18:12 (79 w, 8 m)

Recent Activity

Aug 26 2018

hanchon added a comment to D1686: Use disconnectpool in CTxMemPool::removeForBlock.

All test green 👍

Aug 26 2018, 01:45

Mar 16 2018

hanchon updated the diff for D1150: [WIP] Extensible Blockchain Protocol first approach.

Pushing local changes before traveling to SV
The blocks are fully rejected if they are bigger than a value. (TODO: discuss what max block size whould be ok for this check)
The EBP block's transactions are validated only when their chain have enough PoW to become the active one. (The CheckBlock function was split in two functions)
A basic RPC test was created to simulate an EBP activation using 2 nodes.

Mar 16 2018, 14:34

Mar 5 2018

hanchon added inline comments to D1150: [WIP] Extensible Blockchain Protocol first approach.
Mar 5 2018, 18:13

Mar 2 2018

hanchon updated the summary of D1150: [WIP] Extensible Blockchain Protocol first approach.
Mar 2 2018, 21:08
Herald added a reviewer for D1150: [WIP] Extensible Blockchain Protocol first approach: Restricted Project.
Mar 2 2018, 21:01

Sep 6 2017

hanchon added inline comments to D512: Store the UTXO set on a per output basis rather than a per transaction basis.
Sep 6 2017, 18:38

Sep 5 2017

hanchon added a comment to T100: (EC) Functionality to check all the consensus rules on excessive blocks .

Code here: D522

Sep 5 2017, 04:26
hanchon retitled D522: (EC) CheckBlock flag to ignore excessive blocks validations from CheckBlock flag to ignore excessive blocks validations to (EC) CheckBlock flag to ignore excessive blocks validations.
Sep 5 2017, 04:26
Herald added a reviewer for D522: (EC) CheckBlock flag to ignore excessive blocks validations: Restricted Project.
Sep 5 2017, 04:25
hanchon added a revision to T100: (EC) Functionality to check all the consensus rules on excessive blocks : D522: (EC) CheckBlock flag to ignore excessive blocks validations.
Sep 5 2017, 04:25

Sep 1 2017

hanchon added a comment to T95: (EC) Split the EC code in smaller task.

Function to validate the missing consensus rules on EC blocks: T100

Sep 1 2017, 14:14
hanchon created T100: (EC) Functionality to check all the consensus rules on excessive blocks .
Sep 1 2017, 14:12
hanchon added a comment to T98: (EC) Save the Excessive blocks.

The code is here D519

Sep 1 2017, 03:22
Herald added a reviewer for D519: Save the excessive blocks: Restricted Project.
Sep 1 2017, 03:21
hanchon added a revision to T98: (EC) Save the Excessive blocks: D519: Save the excessive blocks.
Sep 1 2017, 03:21

Aug 29 2017

hanchon added a comment to T95: (EC) Split the EC code in smaller task.

Store the blocks: T98

Aug 29 2017, 23:15
hanchon created T98: (EC) Save the Excessive blocks.
Aug 29 2017, 23:15

Aug 28 2017

hanchon added inline comments to D484: Excessive blocks flag and mode.
Aug 28 2017, 22:28
hanchon updated the test plan for D484: Excessive blocks flag and mode.
Aug 28 2017, 22:22
hanchon updated the diff for D484: Excessive blocks flag and mode.

IsNotValid method created to group the excessive and invalid modes.
Added tests for the IsNotValid and IsExcessive functions.
Created new flag for blocks not valid, using the previous not valid block flag + the is excessive flag.
Mode Excessive moved to second position in the ValidationState to represent that the invalid mode is more restrictive.
Ban score when validating an excessive block modified to 10. (It may need to be lower)

Aug 28 2017, 22:21
hanchon abandoned D483: Clang-format applied to some files.

I installed clang-format 3.8 and this changes are no longer needed.

Aug 28 2017, 13:49

Aug 25 2017

hanchon added a comment to T94: (EC) Mark the block as excessive.

It's being coded here D484

Aug 25 2017, 04:37
hanchon added a revision to T94: (EC) Mark the block as excessive: D484: Excessive blocks flag and mode.
Aug 25 2017, 04:34
Herald added a reviewer for D484: Excessive blocks flag and mode: Restricted Project.
Aug 25 2017, 04:34
Herald added a reviewer for D483: Clang-format applied to some files: Restricted Project.
Aug 25 2017, 04:24

Aug 23 2017

hanchon added a comment to T95: (EC) Split the EC code in smaller task.

The first task is this: https://reviews.bitcoinabc.org/T94

Aug 23 2017, 14:52
hanchon created T95: (EC) Split the EC code in smaller task.
Aug 23 2017, 14:51
hanchon created T94: (EC) Mark the block as excessive.
Aug 23 2017, 14:47
hanchon committed rABC2ea663975845: autopep8 rpc-tests.py (authored by hanchon).
autopep8 rpc-tests.py
Aug 23 2017, 00:01
hanchon closed D476: autopep8 rpc-tests.py by committing rABC2ea663975845: autopep8 rpc-tests.py.
Aug 23 2017, 00:01

Aug 22 2017

Herald added a reviewer for D476: autopep8 rpc-tests.py: Restricted Project.
Aug 22 2017, 21:19
hanchon added a comment to D443: WIP - EC: basic forking test and basic block size check.

The autopep8 changes weren't in the master branch, i'll create a new diff with them

Aug 22 2017, 20:57
hanchon updated the diff for D443: WIP - EC: basic forking test and basic block size check.

rebase to current master to get the autopep8 changes in the rpc-tests.py file

Aug 22 2017, 20:54

Aug 20 2017

hanchon updated the diff for D443: WIP - EC: basic forking test and basic block size check.

Removed blocksize code. Moved block check to the globalconfig. Fixed index error in FindMostWorkChain.

Aug 20 2017, 00:30

Aug 15 2017

hanchon updated the diff for D443: WIP - EC: basic forking test and basic block size check.

Removed BU code and saved not valid yet chain to be reevaluated.
TODO: fix bug with iterators, update policy values when a new chain is accepted, change variables names to something smaller.

Aug 15 2017, 04:22

Aug 10 2017

hanchon added a comment to D443: WIP - EC: basic forking test and basic block size check.

When I have the smaller diffs ready, I'll link them so the code can be reviewed easily. The smaller diff will have the tests and the hardcoded values will get their values from global variables.

Aug 10 2017, 03:19
hanchon updated the diff for D443: WIP - EC: basic forking test and basic block size check.

Trying the bitcoin unlimited EC code.
There are many changes and not everything has its test. I'm going to separate this diff in 2 or 3 smaller diff (each one with their tests) so it can be reviewed.

Aug 10 2017, 03:14

Aug 8 2017

Herald added a reviewer for D443: WIP - EC: basic forking test and basic block size check: Restricted Project.
Aug 8 2017, 04:21

Aug 5 2017

hanchon accepted D422: Various nits in miner.cpp , mostly braces.
Aug 5 2017, 14:15
hanchon added a comment to D422: Various nits in miner.cpp , mostly braces.

It looks good, make check is green.

Aug 5 2017, 14:15
hanchon added a comment to D420: Fix bip68-112-113-p2p.py.

The test is passing with this changes

Aug 5 2017, 14:02

Jul 28 2017

hanchon committed rABCb5e9de2c0440: The clear function in CTxMemPool do not clear the member vTxHashes (authored by hanchon).
The clear function in CTxMemPool do not clear the member vTxHashes
Jul 28 2017, 23:41
hanchon closed D392: The clear function in CTxMemPool do not clear the member vTxHashes by committing rABCb5e9de2c0440: The clear function in CTxMemPool do not clear the member vTxHashes.
Jul 28 2017, 23:41
hanchon updated the diff for D392: The clear function in CTxMemPool do not clear the member vTxHashes.

Checking CTxMemPool's members to be empty

Jul 28 2017, 23:36
Herald added a reviewer for D392: The clear function in CTxMemPool do not clear the member vTxHashes: Restricted Project.
Jul 28 2017, 23:13

Jun 21 2017

hanchon committed rABC2d7182327797: Fixed mempool test, block size was not needed to be set to test the mempool (authored by hanchon).
Fixed mempool test, block size was not needed to be set to test the mempool
Jun 21 2017, 16:13
hanchon closed D244: Fixed mempool test, block size was not needed to be set to test the mempool by committing rABC2d7182327797: Fixed mempool test, block size was not needed to be set to test the mempool.
Jun 21 2017, 16:13
Herald added a reviewer for D244: Fixed mempool test, block size was not needed to be set to test the mempool: Restricted Project.
Jun 21 2017, 16:11
hanchon committed rABC29dbc00975d4: p2sh txns added to the mempool (authored by hanchon).
p2sh txns added to the mempool
Jun 21 2017, 13:22
hanchon closed D239: p2sh txns added to the mempool by committing rABC29dbc00975d4: p2sh txns added to the mempool.
Jun 21 2017, 13:22
hanchon updated the diff for D239: p2sh txns added to the mempool.

Test renamed to mempool-accept-txn.py
Test name also was edited in the qa/pull-tester/rpc-tests.py file
Added missing end line at the end of the abc-p2p-fullblocktest.py file (that line was not copied when copy-pasted the original abc-p2p-fullblocktest.py code to revert the changes)

Jun 21 2017, 12:54
hanchon added inline comments to D239: p2sh txns added to the mempool.
Jun 21 2017, 12:10
hanchon updated the test plan for D239: p2sh txns added to the mempool.
Jun 21 2017, 12:09
hanchon updated the diff for D239: p2sh txns added to the mempool.

Reverted changes on abc-p2p-fullblocktest.py
Created new test named mempool_p2sh_txn.py derived from p2p-fullblocktest
The new test was added to the qa/pull-tester/rpc-tests.py
MAX_STANDARD_TX_SIGOPS was declared in the qa/rpc-tests/test-framework/cdefs.py file

Jun 21 2017, 03:24

Jun 20 2017

hanchon added inline comments to D239: p2sh txns added to the mempool.
Jun 20 2017, 18:13
Herald added a reviewer for D239: p2sh txns added to the mempool: Restricted Project.
Jun 20 2017, 18:12

Jun 19 2017

hanchon accepted D223: Update DNS seeds.

The bitprim seeds are OK

Jun 19 2017, 18:44

Jun 16 2017

hanchon committed rABC207f2e1281cc: testing bad-txn-sigops using p2sh (authored by hanchon).
testing bad-txn-sigops using p2sh
Jun 16 2017, 13:42
hanchon closed D209: testing bad-txn-sigops using p2sh by committing rABC207f2e1281cc: testing bad-txn-sigops using p2sh.
Jun 16 2017, 13:42
hanchon updated the diff for D209: testing bad-txn-sigops using p2sh.

Using create_and_sign_transaction method to create the p2sh_tx
Removed b30 local variable
Using p2sh_tx variable instead of the first block transaction in the spend_p2sh_tx method

Jun 16 2017, 00:44
hanchon added inline comments to D209: testing bad-txn-sigops using p2sh.
Jun 16 2017, 00:36

Jun 15 2017

hanchon updated the diff for D209: testing bad-txn-sigops using p2sh.

Requested changes applied

Jun 15 2017, 22:01
Herald added a reviewer for D209: testing bad-txn-sigops using p2sh: Restricted Project.
Jun 15 2017, 18:48