Page MenuHomePhabricator

Clang-format applied to some files
AbandonedPublic

Authored by hanchon on Aug 25 2017, 04:24.

Details

Reviewers
CCulianu
Group Reviewers
Restricted Project
Summary

Uploading only the format changes here, to keep clean the other diff.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clang-format
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 756
Build 756: arc lint + arc unit

Event Timeline

Looks like you are using a clang format version that isn't 3.8 . We settled on 3.8 so far. We'll do a mass format when we move to 4.0 .

This revision is now accepted and ready to land.Aug 26 2017, 20:03

No this is not good. This will cause the formattign to oscillate. These files are already formatted, but clang changed something in clang format 4.0 so one need to use a pre 4.0 version. Or we move to 4.0 but then we need to format it all once and for all.

I installed clang-format 3.8 and this changes are no longer needed.