Page MenuHomePhabricator

Save the excessive blocks
AbandonedPublic

Authored by jasonbcox on Sep 1 2017, 03:21.

Details

Reviewers
deadalnix
hanchon
Group Reviewers
Restricted Project
Maniphest Tasks
T98: (EC) Save the Excessive blocks
Summary

The excessive blocks are now saved before returning the error message.
The blocks saved are not fully validated. The validation process should be done when that chain is going to be activated.
The best chain selector is now ignoring excessive blocks to avoid activating an EC chain.
TODO: verify the blocks status when running node with -prune

Test Plan

python3 qa/pull-tester/rpc-tests.py abc-ec

Diff Detail

Repository
rABC Bitcoin ABC
Branch
T98-save
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 820
Build 820: arc lint + arc unit

Event Timeline

deadalnix added inline comments.
src/chain.h
331

The same logic can be done via:

return !(nStatus & BLOCK_EXCESSIVE)

But that seems backward to me. If the excessive flag is set, then should that indicate that tej block is excessive rather than it isn't ?

deadalnix requested changes to this revision.Dec 5 2017, 14:26

Back on your queue.

This revision now requires changes to proceed.Dec 5 2017, 14:26
jasonbcox abandoned this revision.
jasonbcox added a reviewer: hanchon.

Cleaning up old diffs. Abandoning this to clear it off the review board.