Save the excessive blocks
AbandonedPublic
Actions

Authored by jasonbcox on Sep 1 2017, 03:21.

Details

Reviewers

deadalnix
hanchon

Group Reviewers

Restricted Project

Maniphest Tasks

T98: (EC) Save the Excessive blocks

Summary

The excessive blocks are now saved before returning the error message.
The blocks saved are not fully validated. The validation process should be done when that chain is going to be activated.
The best chain selector is now ignoring excessive blocks to avoid activating an EC chain.
TODO: verify the blocks status when running node with -prune

Test Plan

python3 qa/pull-tester/rpc-tests.py abc-ec

Diff Detail

Repository

rABC Bitcoin ABC

Branch

T98-save

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 820
Build 820: arc lint + arc unit

Event Timeline

hanchon created this revision.Sep 1 2017, 03:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2017, 03:21

Harbormaster completed remote builds in B820: Diff 1305.Sep 1 2017, 03:21

hanchon mentioned this in T98: (EC) Save the Excessive blocks.Sep 1 2017, 03:22

deadalnix added a subscriber: deadalnix.Sep 4 2017, 12:19

deadalnix added inline comments.

src/chain.h
331	The same logic can be done via: return !(nStatus & BLOCK_EXCESSIVE) But that seems backward to me. If the excessive flag is set, then should that indicate that tej block is excessive rather than it isn't ?