HomePhabricator

scheduler: don't rely on boost interrupt on shutdown

Description

scheduler: don't rely on boost interrupt on shutdown

Summary:
Calling interrupt_all() will immediately stop the scheduler, so it's
safe to invoke stop() beforehand, and this removes the reliance on boost
to interrupt serviceQueue().

This is a partial abckport of Core PR18234 : https://github.com/bitcoin/bitcoin/pull/18234/commits/306f71b4eb4a0fd8e64f47dc008bc235b80b13d9

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6531

Details

Provenance
Anthony Towns <aj@erisian.com.au>Authored on Feb 28 2020, 02:02
deadalnixCommitted on Jun 11 2020, 12:57
deadalnixPushed on Jun 11 2020, 12:57
Reviewer
Restricted Project
Differential Revision
D6531: scheduler: don't rely on boost interrupt on shutdown
Parents
rABC72ebb4217e4f: UninterruptibleSleep in avalanche test
Branches
Unknown
Tags
Unknown