Page MenuHomePhabricator
Differential D6531

scheduler: don't rely on boost interrupt on shutdown
ClosedPublic
Actions

Authored by deadalnix on Jun 11 2020, 11:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC014e5697a60a: scheduler: don't rely on boost interrupt on shutdown
Summary

Calling interrupt_all() will immediately stop the scheduler, so it's
safe to invoke stop() beforehand, and this removes the reliance on boost
to interrupt serviceQueue().

This is a partial abckport of Core PR18234 : https://github.com/bitcoin/bitcoin/pull/18234/commits/306f71b4eb4a0fd8e64f47dc008bc235b80b13d9

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 11 2020, 11:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2020, 11:51
deadalnix requested review of this revision.Jun 11 2020, 11:51
teamcity edited the summary of this revision. (Show Details)Jun 11 2020, 11:51

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D6532: sync.h: add REVERSE_LOCK.Jun 11 2020, 11:59
Harbormaster completed remote builds in B11420: Diff 21276.Jun 11 2020, 12:05
Fabien accepted this revision.Jun 11 2020, 12:41
This revision is now accepted and ready to land.Jun 11 2020, 12:41
Closed by commit rABC014e5697a60a: scheduler: don't rely on boost interrupt on shutdown (authored by Anthony Towns <aj@erisian.com.au>, committed by deadalnix). · Explain WhyJun 11 2020, 12:57
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC014e5697a60a: scheduler: don't rely on boost interrupt on shutdown.

Revision Contents
Changeset List

PathSize
src/
3 lines
test/
2 lines
util/
3 lines

Diff 21284

View Options

src/init.cpp

Loading...
View Options

src/test/txindex_tests.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...