HomePhabricator

Fix implicit-integer-sign-change in arith_uint256

Description

Fix implicit-integer-sign-change in arith_uint256

Summary:
This refactor doesn't change behaviour, but clarifies that the numbers being dealt with aren't supposed to be negative. This helps when reading the code and allows to remove a sanitizer suppression for the whole file.

This is a backport of core#24059

Depends on D12813

Test Plan:
With UBSAN
ninja && ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12814

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jan 13 2022, 14:57
PiRKCommitted on Dec 9 2022, 07:24
PiRKPushed on Dec 9 2022, 07:24
Reviewer
Restricted Project
Differential Revision
D12814: Fix implicit-integer-sign-change in arith_uint256
Parents
rABC9df212fb7485: Fix implicit integer sign changes in strencodings and reduce size of…
Branches
Unknown
Tags
Unknown