Page MenuHomePhabricator

Fix implicit-integer-sign-change in arith_uint256
ClosedPublic

Authored by PiRK on Dec 8 2022, 12:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC02c21f2efd59: Fix implicit-integer-sign-change in arith_uint256
Summary

This refactor doesn't change behaviour, but clarifies that the numbers being dealt with aren't supposed to be negative. This helps when reading the code and allows to remove a sanitizer suppression for the whole file.

This is a backport of core#24059

Depends on D12813

Test Plan

With UBSAN
ninja && ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable