Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC410613b0ae90: zmq: Fix implicit-integer-sign-change

Summary

uint256::begin() returns unsigned data, so there is no reason to make it signed.

Fix that and remove the sanitizer suppression.

This is a backport of core#24218

Depends on D12817

Test Plan

With UBSAN
ninja && ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 8 2022, 12:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2022, 12:34

PiRK requested review of this revision.Dec 8 2022, 12:34

teamcity edited the summary of this revision. (Show Details)Dec 8 2022, 12:34

PiRK added a child revision: D12819: Fix implicit-integer-sign-change in bloom.Dec 8 2022, 12:35

Harbormaster completed remote builds in B21473: Diff 37122.Dec 8 2022, 13:14

Fabien accepted this revision.Dec 8 2022, 14:49

This revision is now accepted and ready to land.Dec 8 2022, 14:49

Closed by commit rABC410613b0ae90: zmq: Fix implicit-integer-sign-change (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 9 2022, 07:25

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC410613b0ae90: zmq: Fix implicit-integer-sign-change.

zmq: Fix implicit-integer-sign-change
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 37151

src/zmq/zmqpublishnotifier.cpp

test/sanitizer_suppressions/ubsan

zmq: Fix implicit-integer-sign-changeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37151

src/zmq/zmqpublishnotifier.cpp

test/sanitizer_suppressions/ubsan

zmq: Fix implicit-integer-sign-change
ClosedPublic
Actions

Revision Contents
Changeset List