Paths

Table of Contentst

Differential D12817

refactor: Make MessageBoxFlags enum underlying type unsigned
ClosedPublic
Actions

Authored by PiRK on Dec 8 2022, 12:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC54363e9dbc46: refactor: Make MessageBoxFlags enum underlying type unsigned

Summary

This is a backport of core#24191

Depends on D12816

Test Plan

With UBSAN
ninja && ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 8 2022, 12:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2022, 12:33

PiRK requested review of this revision.Dec 8 2022, 12:33

teamcity edited the summary of this revision. (Show Details)Dec 8 2022, 12:33

PiRK added a child revision: D12818: zmq: Fix implicit-integer-sign-change.Dec 8 2022, 12:34

Harbormaster completed remote builds in B21472: Diff 37121.Dec 8 2022, 13:10

Fabien accepted this revision.Dec 8 2022, 14:49

This revision is now accepted and ready to land.Dec 8 2022, 14:49

Closed by commit rABC54363e9dbc46: refactor: Make MessageBoxFlags enum underlying type unsigned (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 9 2022, 07:25

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC54363e9dbc46: refactor: Make MessageBoxFlags enum underlying type unsigned.

Revision Contents
Changeset List

Path

Size

src/

node/

ui_interface.h

2 lines

test/

sanitizer_suppressions/

ubsan

1 line

Diff 37149

View Options

src/node/ui_interface.h