Paths

Table of Contentst

Differential D12799

refactor: Remove implicit-integer-sign-change suppressions in validation.cpp
ClosedPublic
Actions

Authored by PiRK on Dec 7 2022, 16:47.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCc46c56d237e0: refactor: Remove implicit-integer-sign-change suppressions in validation.cpp

Summary

This is a backport of core#23795

Test Plan

With UBSAN
ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 7 2022, 16:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2022, 16:47

PiRK requested review of this revision.Dec 7 2022, 16:47

teamcity edited the summary of this revision. (Show Details)Dec 7 2022, 16:47

Harbormaster completed remote builds in B21433: Diff 37069.Dec 7 2022, 17:20

sdulfari accepted this revision.Dec 7 2022, 19:21

This revision is now accepted and ready to land.Dec 7 2022, 19:21

rebase

Harbormaster completed remote builds in B21453: Diff 37100.Dec 8 2022, 08:12

PiRK added a child revision: D12812: refactor: Fix implicit-signed-integer-truncation in cuckoocache.h.Dec 8 2022, 12:27

Closed by commit rABCc46c56d237e0: refactor: Remove implicit-integer-sign-change suppressions in validation.cpp (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 9 2022, 07:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc46c56d237e0: refactor: Remove implicit-integer-sign-change suppressions in validation.cpp.

Revision Contents
Changeset List

Path

Size

src/

node/

blockstorage.cpp

4 lines

validation.cpp

8 lines

test/

sanitizer_suppressions/

ubsan

1 line

Diff 37144

View Options

src/node/blockstorage.cpp

View Options

src/validation.cpp

View Options

test/sanitizer_suppressions/ubsan

refactor: Remove implicit-integer-sign-change suppressions in validation.cppClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37144

src/node/blockstorage.cpp

src/validation.cpp

test/sanitizer_suppressions/ubsan

refactor: Remove implicit-integer-sign-change suppressions in validation.cpp
ClosedPublic
Actions

Revision Contents
Changeset List