HomePhabricator

Move ::nPruneTarget into BlockManager

Description

Move ::nPruneTarget into BlockManager

Summary:

It seems preferable to assign globals to a class (in this case BlockManager), than to leave them dangling. This should clarify scope for code-readers, as well as clarifying unit test behaviour.

This is a partial backport of core#25781
https://github.com/bitcoin/bitcoin/pull/25781/commits/fa721f1cab0de239a93f6bf70e3a8af26fddae8a

Depends on D16006

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16007

Details

Provenance
MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>Authored on Jan 3 2023, 12:12
PiRKCommitted on Apr 19 2024, 06:04
PiRKPushed on Apr 19 2024, 06:04
Reviewer
Restricted Project
Differential Revision
D16007: Move ::nPruneTarget into BlockManager
Parents
rABC4990f9bed2bd: Remove reindex special case from the progress bar label
Branches
Unknown
Tags
Unknown