Move ::nPruneTarget into BlockManager
ClosedPublic
Actions

Authored by PiRK on Apr 17 2024, 20:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC03edbead7c24: Move ::nPruneTarget into BlockManager

Summary

It seems preferable to assign globals to a class (in this case BlockManager), than to leave them dangling. This should clarify scope for code-readers, as well as clarifying unit test behaviour.

This is a partial backport of core#25781
https://github.com/bitcoin/bitcoin/pull/25781/commits/fa721f1cab0de239a93f6bf70e3a8af26fddae8a

Depends on D16006

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 17 2024, 20:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2024, 20:12

PiRK requested review of this revision.Apr 17 2024, 20:12

teamcity edited the summary of this revision. (Show Details)Apr 17 2024, 20:12

PiRK added a child revision: D16008: Move ::fPruneMode into BlockManager.Apr 17 2024, 20:14

Harbormaster completed remote builds in B28630: Diff 47251.Apr 17 2024, 20:36

Fabien requested changes to this revision.Apr 18 2024, 15:55

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/node/blockmanager_args.h
1 ↗	(On Diff #47251)	? Also the copyright date mismatch the other new file above, is that expected ?

This revision now requires changes to proceed.Apr 18 2024, 15:55

remove blank line before copyright header

The difference in the copyright years is weird, but not impossible. The PR was opened in 2022 and finally merged in 2023, so maybe some files were added or modified later during the review process

Fabien accepted this revision.Apr 18 2024, 19:52

This revision is now accepted and ready to land.Apr 18 2024, 19:52

Harbormaster completed remote builds in B28646: Diff 47273.Apr 18 2024, 20:00

Closed by commit rABC03edbead7c24: Move ::nPruneTarget into BlockManager (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by PiRK). · Explain WhyApr 19 2024, 06:04

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC03edbead7c24: Move ::nPruneTarget into BlockManager.

PiRK mentioned this in D16388: [Chronik] Add `ParseChronikParams` and use it in chronik::Start.Jun 29 2024, 11:55