[Chronik] Add `ParseChronikParams` and use it in chronik::Start
ClosedPublic
Actions

Authored by tobias_ruck on Jun 28 2024, 19:13.

Details

Reviewers

Fabien
PiRK

Group Reviewers

Restricted Project

Commits

rABC99bd71b032b5: [Chronik] Add `ParseChronikParams` and use it in chronik::Start

Summary

This separates this code into its own function, something we eventually could test also.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Jun 28 2024, 19:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2024, 19:13

tobias_ruck requested review of this revision.Jun 28 2024, 19:13

Harbormaster completed remote builds in B29414: Diff 48414.Jun 28 2024, 20:15

PiRK requested changes to this revision.Jun 29 2024, 11:43

PiRK added a subscriber: PiRK.

PiRK added inline comments.

chronik/chronik-cpp/chronik.cpp
41–70 ↗	(On Diff #48414)

This revision now requires changes to proceed.Jun 29 2024, 11:43

This looks like a good first step to remove most gArgs access (eventually we want the ArgsManager to not be a global).

A next step would be to make chronik not depend on common/args.h (ArgsManager) at all, like we recently did for ChainstateManager, BlockManager (see D16007 for instance) ...

chronik/chronik-cpp/chronik.cpp
77 ↗	(On Diff #48414)

gArgs -> args

Harbormaster completed remote builds in B29457: Diff 48481.Jul 3 2024, 12:11

PiRK accepted this revision.Jul 3 2024, 13:07

This revision is now accepted and ready to land.Jul 3 2024, 13:07

Closed by commit rABC99bd71b032b5: [Chronik] Add `ParseChronikParams` and use it in chronik::Start (authored by tobias_ruck). · Explain WhyJul 3 2024, 17:59

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC99bd71b032b5: [Chronik] Add `ParseChronikParams` and use it in chronik::Start.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-cpp/

chronik.h

3 lines

chronik.cpp

74 lines

src/

init.cpp

2 lines

Diff 48487

View Options

chronik/chronik-cpp/chronik.h

View Options

chronik/chronik-cpp/chronik.cpp

View Options

[Chronik] Add `ParseChronikParams` and use it in chronik::StartClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48487

chronik/chronik-cpp/chronik.h

chronik/chronik-cpp/chronik.cpp

src/init.cpp

[Chronik] Add `ParseChronikParams` and use it in chronik::Start
ClosedPublic
Actions

Revision Contents
Changeset List