Paths

Table of Contentst

Differential D16016

Replace pindex pointer with block reference
ClosedPublic
Actions

Authored by PiRK on Thu, Apr 18, 14:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5cfdcd1e6fcd: Replace pindex pointer with block reference

Summary

pindex can not be nullptr, so document that.

This concludes backport of core#27570
https://github.com/bitcoin/bitcoin/pull/27570/commits/fa3f74a40efa0db3af31438e9250c41bc7406749
(partial) https://github.com/bitcoin/bitcoin/pull/27570/commits/fa5d7c39eb992467e43b12db213b27913374fb83

Depends on D16015

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Thu, Apr 18, 14:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Apr 18, 14:33

PiRK requested review of this revision.Thu, Apr 18, 14:33

teamcity edited the summary of this revision. (Show Details)Thu, Apr 18, 14:33

Harbormaster completed remote builds in B28644: Diff 47271.Thu, Apr 18, 15:00

Fabien accepted this revision.Thu, Apr 18, 16:03

This revision is now accepted and ready to land.Thu, Apr 18, 16:03

Closed by commit rABC5cfdcd1e6fcd: Replace pindex pointer with block reference (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by PiRK). · Explain WhyFri, Apr 19, 06:04

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5cfdcd1e6fcd: Replace pindex pointer with block reference.

Revision Contents
Changeset List

Path

Size

src/

node/

blockstorage.h

2 lines

blockstorage.cpp

16 lines

validation.cpp

2 lines

Diff 47293

View Options

src/node/blockstorage.h

View Options

src/node/blockstorage.cpp

View Options

Replace pindex pointer with block referenceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47293

src/node/blockstorage.h

src/node/blockstorage.cpp

src/validation.cpp

Replace pindex pointer with block reference
ClosedPublic
Actions

Revision Contents
Changeset List