Paths

Table of Contentst

Differential D16009

Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager
ClosedPublic
Actions

Authored by PiRK on Wed, Apr 17, 20:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2b7a66e06daa: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager

Summary

It seems preferable to assign globals to a class (in this case BlockManager), than to leave them dangling. This should clarify scope for code-readers, as well as clarifying unit test behaviour.

This is a partial backport of core#25781
https://github.com/bitcoin/bitcoin/pull/25781/commits/fa442b137764e0b6c0d991ba641e90c3217be1bf
https://github.com/bitcoin/bitcoin/pull/25781/commits/fa9bd7be472f49b15f5f87711094095954322635

Depends on D16008

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Apr 17, 20:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 17, 20:16

PiRK requested review of this revision.Wed, Apr 17, 20:16

teamcity edited the summary of this revision. (Show Details)Wed, Apr 17, 20:17

PiRK added a child revision: D16010: refactor: Add and use PRUNE_TARGET_MANUAL constexpr.Wed, Apr 17, 20:20

Harbormaster completed remote builds in B28632: Diff 47253.Wed, Apr 17, 20:50

Fabien accepted this revision.Thu, Apr 18, 15:57

This revision is now accepted and ready to land.Thu, Apr 18, 15:57

Closed by commit rABC2b7a66e06daa: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by PiRK). · Explain WhyFri, Apr 19, 06:04

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2b7a66e06daa: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager.

Revision Contents
Changeset List

Path

Size

src/

node/

blockstorage.h

5 lines

blockstorage.cpp

23 lines

interfaces.cpp

2 lines

Diff 47290

View Options

src/node/blockstorage.h

View Options

src/node/blockstorage.cpp

View Options

Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManagerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47290

src/node/blockstorage.h

src/node/blockstorage.cpp

src/node/interfaces.cpp

Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager
ClosedPublic
Actions

Revision Contents
Changeset List