HomePhabricator

Move ::fPruneMode into BlockManager

Description

Move ::fPruneMode into BlockManager

Summary:

It seems preferable to assign globals to a class (in this case BlockManager), than to leave them dangling. This should clarify scope for code-readers, as well as clarifying unit test behaviour.

This is a partial backport of core#25781
https://github.com/bitcoin/bitcoin/pull/25781/commits/fa177d7b6b3ad008d442ff9622c9b30e68d6e388
Depends on D16007

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16008

Details

Provenance
MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>Authored on Jan 3 2023, 11:47
PiRKCommitted on Fri, Apr 19, 06:04
PiRKPushed on Fri, Apr 19, 06:04
Reviewer
Restricted Project
Differential Revision
D16008: Move ::fPruneMode into BlockManager
Parents
rABC03edbead7c24: Move ::nPruneTarget into BlockManager
Branches
Unknown
Tags
Unknown