HomePhabricator

Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager

Description

Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager

Summary:

It seems preferable to assign globals to a class (in this case BlockManager), than to leave them dangling. This should clarify scope for code-readers, as well as clarifying unit test behaviour.

This is a partial backport of core#25781
https://github.com/bitcoin/bitcoin/pull/25781/commits/fa442b137764e0b6c0d991ba641e90c3217be1bf
https://github.com/bitcoin/bitcoin/pull/25781/commits/fa9bd7be472f49b15f5f87711094095954322635

Depends on D16008

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16009

Details

Provenance
MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>Authored on Jan 3 2023, 12:06
PiRKCommitted on Apr 19 2024, 06:04
PiRKPushed on Apr 19 2024, 06:04
Reviewer
Restricted Project
Differential Revision
D16009: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager
Parents
rABC0f48c6c439a3: Move ::fPruneMode into BlockManager
Branches
Unknown
Tags
Unknown