HomePhabricator
Diffusion Bitcoin ABC 06c00817f205

Improve PID file error handling
06c00817f205
Actions

Description

Improve PID file error handling

Summary:

  • Improve PID file removing errors logging
  • Make PID file creating errors fatal
  • Move all PID file stuff to init.cpp

It is only used from init.cpp.
Move-only refactoring.

This is a backport of Core PR15278

The linter was skipped because we don't have that linter.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5775

Details

Provenance
Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>Authored on Feb 1 2019, 22:33
deadalnixCommitted on Apr 20 2020, 13:03
deadalnixPushed on Apr 20 2020, 13:03
Reviewer
Restricted Project
Differential Revision
D5775: Improve PID file error handling
Parents
rABCa546a8d17f10: Speed up OP_REVERSEBYTES test significantly
Branches
Unknown
Tags
Unknown

Event Timeline

deadalnix committed rABC06c00817f205: Improve PID file error handling (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).Apr 20 2020, 13:03
deadalnix added an edge: D5775: Improve PID file error handling.

Changes (3)

PathSize
src/
util/

rABC06c00817f205

View Options

src/init.cpp

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/util/system.h

Loading...