Page MenuHomePhabricator
Differential D5775

Improve PID file error handling
ClosedPublic
Actions

Authored by deadalnix on Apr 18 2020, 13:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING06c00817f205: Improve PID file error handling
rABC06c00817f205: Improve PID file error handling
Summary
  • Improve PID file removing errors logging
  • Make PID file creating errors fatal
  • Move all PID file stuff to init.cpp

It is only used from init.cpp.
Move-only refactoring.

This is a backport of Core PR15278

The linter was skipped because we don't have that linter.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Apr 18 2020, 13:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2020, 13:50
teamcity edited the summary of this revision. (Show Details)Apr 18 2020, 13:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 18 2020, 13:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 18 2020, 14:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10296: Diff 18939.Apr 18 2020, 14:03
deadalnix added a child revision: D5776: Enable PID file creation on WIN.Apr 18 2020, 14:43
Fabien accepted this revision.Apr 20 2020, 08:39
This revision is now accepted and ready to land.Apr 20 2020, 08:39
Closed by commit rABC06c00817f205: Improve PID file error handling (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by deadalnix). · Explain WhyApr 20 2020, 13:03
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC06c00817f205: Improve PID file error handling.
deadalnix added a commit: rSTAGING06c00817f205: Improve PID file error handling.May 5 2020, 19:02

Revision Contents
Changeset List

PathSize
src/
39 lines
util/
5 lines
16 lines

Diff 18947

View Options

src/init.cpp

Loading...
View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...