HomePhabricator
Diffusion Bitcoin ABC 08a7b78cc44c

[backport#16034] Move LockAnnotation from threadsafety.h (imported code) to…
08a7b78cc44c
Actions

Description

[backport#16034] Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)

Summary:
https://github.com/bitcoin/bitcoin/pull/16034/commits/cc2588579c3fbc133a7ca762fa213ca18b736551

Move LockAnnotation to make it reflect the truth
https://github.com/bitcoin/bitcoin/pull/16034/commits/3a809446b3881e1a6853da78cccf42643c9a5927

Make sure the compile-time locking promises given via LockAnnotation:s hold also in practice at runtime (ifdef DEBUG_LOCKORDER)
https://github.com/bitcoin/bitcoin/pull/16034/commits/de9b5dbca34230b8213ce612036fccabdb6ee53b

Depends on D6259

Partial backport of Core PR16034

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6261

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on May 16 2019, 09:25
majcostaCommitted on May 27 2020, 19:34
majcostaPushed on May 27 2020, 19:34
Reviewer
Restricted Project
Differential Revision
D6261: [backport#16034] Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
Parents
rABC0ae0f30d6b9f: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main
Branches
Unknown
Tags
Unknown

Changes (3)

PathSize
src/
wallet/
test/

rABC08a7b78cc44c

View Options

src/sync.h

Loading...
View Options

src/threadsafety.h

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...