Page MenuHomePhabricator

[backport#16034] Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
ClosedPublic

Authored by majcosta on May 26 2020, 20:06.

Details

Summary

https://github.com/bitcoin/bitcoin/pull/16034/commits/cc2588579c3fbc133a7ca762fa213ca18b736551


Move LockAnnotation to make it reflect the truth
https://github.com/bitcoin/bitcoin/pull/16034/commits/3a809446b3881e1a6853da78cccf42643c9a5927


Make sure the compile-time locking promises given via LockAnnotation:s hold also in practice at runtime (ifdef DEBUG_LOCKORDER)
https://github.com/bitcoin/bitcoin/pull/16034/commits/de9b5dbca34230b8213ce612036fccabdb6ee53b


Depends on D6259

Partial backport of Core PR16034

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 26 2020, 20:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 20:06
majcosta requested review of this revision.May 26 2020, 20:06
teamcity edited the summary of this revision. (Show Details)May 26 2020, 20:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the summary of this revision. (Show Details)May 26 2020, 21:55
majcosta edited the summary of this revision. (Show Details)
deadalnix accepted this revision.May 27 2020, 11:49
This revision is now accepted and ready to land.May 27 2020, 11:49