Page MenuHomePhabricator
Differential D6258

[backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction
ClosedPublic
Actions

Authored by majcosta on May 26 2020, 13:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC6a41e8229ce3: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction
Summary

Comment SignTransaction utility

https://github.com/bitcoin/bitcoin/pull/15784/commits/99e88a3726c2325e3a3a35c0a750bde25bd58ad0

Depends on D6257

Backport of Core PR15784

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 26 2020, 13:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 13:36
majcosta requested review of this revision.May 26 2020, 13:36
teamcity edited the summary of this revision. (Show Details)May 26 2020, 13:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 26 2020, 13:37

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 13:39

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 13:39

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 13:40

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 13:45

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 13:50

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11029: Diff 20616.May 26 2020, 13:50
majcosta added a child revision: D6259: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main.May 26 2020, 15:15
majcosta added a child revision: D6260: [backport#15842] refactor: replace isPotentialtip/waitForNotifications by higher method.May 26 2020, 17:06
majcosta updated this revision to Diff 20623.May 26 2020, 18:09

rebase

teamcity added a comment.May 26 2020, 18:10

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 18:10

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 18:11

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 18:12

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 18:15

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 18:21

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11036: Diff 20623.May 26 2020, 18:21
deadalnix requested changes to this revision.May 27 2020, 11:44
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
3810 ↗(On Diff #20623)

Comment on its own line.

This revision now requires changes to proceed.May 27 2020, 11:44
majcosta updated this revision to Diff 20641.May 27 2020, 14:53

fixed comment

teamcity added a comment.May 27 2020, 14:55

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 27 2020, 14:55

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 27 2020, 14:55

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.May 27 2020, 14:55
This revision is now accepted and ready to land.May 27 2020, 14:55
teamcity added a comment.May 27 2020, 14:57

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

This revision was landed with ongoing or failed builds.May 27 2020, 14:58
Closed by commit rABC6a41e8229ce3: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC6a41e8229ce3: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.
teamcity added a comment.May 27 2020, 15:00

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 27 2020, 15:07

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11049: Diff 20641.May 27 2020, 15:07

Revision Contents
Changeset List

PathSize
src/
rpc/
13 lines
31 lines
21 lines
wallet/
12 lines

Diff 20642

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/rawtransaction_util.h

Loading...
View Options

src/rpc/rawtransaction_util.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...