Page MenuHomePhabricator

[backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction
ClosedPublic

Authored by majcosta on May 26 2020, 13:36.

Details

Summary
Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 26 2020, 13:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 13:36
majcosta requested review of this revision.May 26 2020, 13:36
teamcity edited the summary of this revision. (Show Details)May 26 2020, 13:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 27 2020, 11:44
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
3810 ↗(On Diff #20623)

Comment on its own line.

This revision now requires changes to proceed.May 27 2020, 11:44
majcosta updated this revision to Diff 20641.May 27 2020, 14:53

fixed comment

deadalnix accepted this revision.May 27 2020, 14:55
This revision is now accepted and ready to land.May 27 2020, 14:55
This revision was landed with ongoing or failed builds.May 27 2020, 14:58
This revision was automatically updated to reflect the committed changes.