Page MenuHomePhabricator
Differential D6260

[backport#15842] refactor: replace isPotentialtip/waitForNotifications by higher method
ClosedPublic
Actions

Authored by majcosta on May 26 2020, 17:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC7f8a7a1b1601: [backport#15842] refactor: replace isPotentialtip/waitForNotifications by…
Summary

Add GUARDED_BY(cs_wallet) annotation to m_last_block_processed, given
that its now guarded by cs_wallet instead of cs_main
https://github.com/bitcoin/bitcoin/pull/15842/commits/422677963a7b41e340b911b4cd53d29dd8d63f21

Add WITH_LOCK macro: run code while locking a mutex
Results from ryanofksy suggestion on isPotentialTip/
waitForNotifications refactoring
https://github.com/bitcoin/bitcoin/pull/15842/commits/edfe9438ca54274815f076fc21beb790df5aa0a2

Depends on D6258

Backport of Core PR15842

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 26 2020, 17:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 17:06
majcosta requested review of this revision.May 26 2020, 17:06
teamcity edited the summary of this revision. (Show Details)May 26 2020, 17:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 26 2020, 17:06

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 17:06

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 17:07

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 17:09

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 17:12

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 17:19

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11031: Diff 20618.May 26 2020, 17:19
majcosta added a child revision: D6259: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main.May 26 2020, 17:39
majcosta updated this revision to Diff 20624.May 26 2020, 18:10

rebase

teamcity added a comment.May 26 2020, 18:12

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 18:13

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 18:15

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 18:16

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 18:16

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 18:26

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11037: Diff 20624.May 26 2020, 18:26
deadalnix accepted this revision.May 27 2020, 11:48
This revision is now accepted and ready to land.May 27 2020, 11:48
Closed by commit rABC7f8a7a1b1601: [backport#15842] refactor: replace isPotentialtip/waitForNotifications by… (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhyMay 27 2020, 15:04
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC7f8a7a1b1601: [backport#15842] refactor: replace isPotentialtip/waitForNotifications by….

Revision Contents
Changeset List

PathSize
src/
interfaces/
18 lines
23 lines
14 lines
wallet/
2 lines
25 lines

Diff 20643

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/sync.h

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...