Page MenuHomePhabricator

[backport#15842] refactor: replace isPotentialtip/waitForNotifications by higher method
ClosedPublic

Authored by majcosta on May 26 2020, 17:06.

Details

Summary

Add GUARDED_BY(cs_wallet) annotation to m_last_block_processed, given
that its now guarded by cs_wallet instead of cs_main
https://github.com/bitcoin/bitcoin/pull/15842/commits/422677963a7b41e340b911b4cd53d29dd8d63f21


Add WITH_LOCK macro: run code while locking a mutex
Results from ryanofksy suggestion on isPotentialTip/
waitForNotifications refactoring
https://github.com/bitcoin/bitcoin/pull/15842/commits/edfe9438ca54274815f076fc21beb790df5aa0a2


Depends on D6258

Backport of Core PR15842

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 27 2020, 11:48