Page MenuHomePhabricator
Differential D6273

[backport#15713] Add BroadcastTransaction utility usage in Chain interface
ClosedPublic
Actions

Authored by majcosta on May 28 2020, 01:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC861bd1645c2c: [backport#15713] Add BroadcastTransaction utility usage in Chain interface
Summary

Access through a broadcastTransaction method.
Add a wait_callback flag to turn off race protection when wallet
already track its tx being in mempool

Standardise highfee, absurdfee variable name to max_tx_fee

We drop the P2P check in BroadcastTransaction as g_connman is only
called by RPCs and the wallet scheduler, both of which are initialized
after g_connman is assigned and stopped before g_connman is reset.

https://github.com/bitcoin/bitcoin/pull/15713/commits/8c8aa19b4b4fa56cd359092ef099bcfc7b26c334

Depends on D6272

Partial backport of Core PR15713

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 28 2020, 01:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 01:05
majcosta requested review of this revision.May 28 2020, 01:05
teamcity edited the summary of this revision. (Show Details)May 28 2020, 01:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 28 2020, 01:06

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 28 2020, 01:06

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 28 2020, 01:06

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 28 2020, 01:07

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 28 2020, 01:09

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 28 2020, 01:18

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11058: Diff 20657.May 28 2020, 01:18
Fabien accepted this revision.May 28 2020, 08:34
This revision is now accepted and ready to land.May 28 2020, 08:34
Closed by commit rABC861bd1645c2c: [backport#15713] Add BroadcastTransaction utility usage in Chain interface (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhyMay 28 2020, 14:11
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC861bd1645c2c: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.

Revision Contents
Changeset List

PathSize
src/
interfaces/
15 lines
16 lines
node/
14 lines
28 lines
rpc/
10 lines

Diff 20670

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/node/transaction.h

Loading...
View Options

src/node/transaction.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...