Page MenuHomePhabricator
Differential D6257

[backport#15670] refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
ClosedPublic
Actions

Authored by majcosta on May 26 2020, 13:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC6f4857cdbc11: [backport#15670] refactor: combine Chain…
Summary

As suggested in #14711, pass height to CChain::FindEarliestAtLeast to
simplify Chain interface by combining findFirstBlockWithTime and
findFirstBlockWithTimeAndHeight into one

Extend findearliestatleast_edge_test in consequence

https://github.com/bitcoin/bitcoin/pull/15670/commits/765c0b364d41e9a251c3f88cbe203645854fd790

Depends on D6256

Backport of Core PR15670

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 26 2020, 13:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 13:08
majcosta requested review of this revision.May 26 2020, 13:08
teamcity edited the summary of this revision. (Show Details)May 26 2020, 13:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 26 2020, 13:09

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 13:09

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 13:09

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 13:11

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 13:13

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 13:21

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11028: Diff 20612.May 26 2020, 13:21
majcosta added a child revision: D6258: [backport#15784] rpc: Remove dependency on interfaces::Chain in SignTransaction.May 26 2020, 13:36
majcosta updated this revision to Diff 20622.May 26 2020, 18:08

rebase

teamcity added a comment.May 26 2020, 18:08

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 18:09

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 18:09

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 18:10

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 18:13

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 18:19

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11035: Diff 20622.May 26 2020, 18:19
deadalnix accepted this revision.May 27 2020, 11:43
This revision is now accepted and ready to land.May 27 2020, 11:43
Closed by commit rABC6f4857cdbc11: [backport#15670] refactor: combine Chain… (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhyMay 27 2020, 14:49
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC6f4857cdbc11: [backport#15670] refactor: combine Chain….

Revision Contents
Changeset List

PathSize
src/
5 lines
15 lines
interfaces/
20 lines
23 lines
rpc/
4 lines
test/
47 lines
wallet/
7 lines

Diff 20640

View Options

src/chain.h

Loading...
View Options

src/chain.cpp

Loading...
View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/skiplist_tests.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...