Page MenuHomePhabricator

[backport#15670] refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
ClosedPublic

Authored by majcosta on May 26 2020, 13:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC6f4857cdbc11: [backport#15670] refactor: combine Chain…
Summary

As suggested in #14711, pass height to CChain::FindEarliestAtLeast to
simplify Chain interface by combining findFirstBlockWithTime and
findFirstBlockWithTimeAndHeight into one

Extend findearliestatleast_edge_test in consequence


https://github.com/bitcoin/bitcoin/pull/15670/commits/765c0b364d41e9a251c3f88cbe203645854fd790

Depends on D6256

Backport of Core PR15670

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 26 2020, 13:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 13:08
majcosta requested review of this revision.May 26 2020, 13:08
teamcity edited the summary of this revision. (Show Details)May 26 2020, 13:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.May 27 2020, 11:43
This revision is now accepted and ready to land.May 27 2020, 11:43
This revision was automatically updated to reflect the committed changes.