Page MenuHomePhabricator

[backport#15492] [rpc] remove deprecated generate method
AbandonedPublic

Authored by majcosta on May 27 2020, 23:11.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Summary
Test Plan
ninja check-all

Event Timeline

majcosta created this revision.May 27 2020, 23:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2020, 23:11
majcosta requested review of this revision.May 27 2020, 23:11
teamcity edited the summary of this revision. (Show Details)May 27 2020, 23:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added inline comments.May 27 2020, 23:38
doc/release-notes.md
48

there is no low-level changes section below

nakihito requested changes to this revision.EditedMay 28 2020, 00:32
nakihito added a subscriber: nakihito.

The summary makes it seem like these are two unrelated commits when they're actually from the same PR. Since they are from the same PR, you don't need to link the individual commits.

Also not sure what D6262 has to do with this patch.

doc/release-notes.md
9

This is the version Core deprecated the RPC with. We deprecated with v0.21.5.

48

This change has nothing to do with the PR.

src/CMakeLists.txt
439

I don't see the equivalent anywhere in the two linked commits?

This revision now requires changes to proceed.May 28 2020, 00:32
majcosta edited the summary of this revision. (Show Details)May 28 2020, 01:07
nakihito added inline comments.May 28 2020, 01:35
src/wallet/rpcwallet.cpp
3849

This PR actually needs to wait for v0.22.

majcosta abandoned this revision.EditedMay 28 2020, 02:08

can't be removed until v0.22