Page MenuHomePhabricator

[backport#15639] Remove access to node globals from wallet-linked code
ClosedPublic

Authored by majcosta on May 26 2020, 12:03.

Details

Summary

Remove last few instances of accesses to node global variables from wallet
code. Also remove accesses to node globals from code in policy/policy.cpp that
isn't actually called by wallet code, but does get linked into wallet code.

This is the last change needed to allow bitcoin-wallet tool to be linked
without depending on libbitcoin_server.a, to ensure wallet code doesn't access
node global state and avoid bugs like
https://github.com/bitcoin/bitcoin/pull/15557#discussion_r267735431


https://github.com/bitcoin/bitcoin/pull/15639/commits/b874747b51882a613895a100c4210c7f1dddde30


Depends on D6233

Partial backport of Core PR15639

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 26 2020, 21:26
deadalnix added a subscriber: deadalnix.

Can you point to the specific part you backported so that we don't need to play where is waldo?

This revision now requires changes to proceed.May 26 2020, 21:26
This revision is now accepted and ready to land.May 27 2020, 12:02