Differential D6255

[backport#15639] Remove access to node globals from wallet-linked code
ClosedPublic
Actions

Authored by majcosta on May 26 2020, 12:03.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC103cee9a7fca: [backport#15639] Remove access to node globals from wallet-linked code

Summary

Remove last few instances of accesses to node global variables from wallet
code. Also remove accesses to node globals from code in policy/policy.cpp that
isn't actually called by wallet code, but does get linked into wallet code.

This is the last change needed to allow bitcoin-wallet tool to be linked
without depending on libbitcoin_server.a, to ensure wallet code doesn't access
node global state and avoid bugs like
https://github.com/bitcoin/bitcoin/pull/15557#discussion_r267735431

https://github.com/bitcoin/bitcoin/pull/15639/commits/b874747b51882a613895a100c4210c7f1dddde30

Depends on D6233

Partial backport of Core PR15639

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11033
Build 20404: Default Diff Build & Tests
Build 20403: Build without Wallet
Build 20402: Build with clang-10
Build 20401: arc lint + arc unit

Event Timeline

majcosta created this revision.May 26 2020, 12:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 12:03

majcosta requested review of this revision.May 26 2020, 12:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

majcosta added a child revision: D6256: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.May 26 2020, 12:18

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11026: Diff 20610.May 26 2020, 12:21

rebase

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11033: Diff 20620.May 26 2020, 18:17

Can you point to the specific part you backported so that we don't need to play where is waldo?

This revision now requires changes to proceed.May 26 2020, 21:26

majcosta edited the summary of this revision. (Show Details)May 26 2020, 21:53

done

deadalnix accepted this revision.May 27 2020, 12:02

This revision is now accepted and ready to land.May 27 2020, 12:02

Closed by commit rABC103cee9a7fca: [backport#15639] Remove access to node globals from wallet-linked code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyMay 27 2020, 14:15

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC103cee9a7fca: [backport#15639] Remove access to node globals from wallet-linked code.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

15 lines

8 lines

policy/

11 lines

7 lines

10 lines

rpc/

rawtransaction.cpp

1 line

wallet/

5 lines

1 line

Diff 20620

src/interfaces/chain.h

Loading...

src/interfaces/chain.cpp

Loading...

src/policy/policy.h

Loading...

src/policy/policy.cpp

Loading...

src/policy/settings.h

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/wallet.cpp

Loading...