Page MenuHomePhabricator

[backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility
ClosedPublic

Authored by majcosta on May 28 2020, 00:07.

Details

Summary

To do so, we also refactor RelayTransaction to take a txid
instead of passing a tx


https://github.com/bitcoin/bitcoin/pull/16452/commits/9bc8b28c1d26c28edf4bbc890be97c0ad7a73cb9

Backport of Core PR16452

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 28 2020, 00:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 00:07
majcosta requested review of this revision.May 28 2020, 00:07
teamcity edited the summary of this revision. (Show Details)May 28 2020, 00:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Not sure what D6262 has to do with this patch?

majcosta edited the summary of this revision. (Show Details)May 28 2020, 02:09
Fabien accepted this revision.May 28 2020, 08:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.h
132 ↗(On Diff #20656)

const TxId &txid

This revision is now accepted and ready to land.May 28 2020, 08:16