Page MenuHomePhabricator
Differential D6272

[backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility
ClosedPublic
Actions

Authored by majcosta on May 28 2020, 00:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCac6a10c8b69a: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility
Summary

To do so, we also refactor RelayTransaction to take a txid
instead of passing a tx

https://github.com/bitcoin/bitcoin/pull/16452/commits/9bc8b28c1d26c28edf4bbc890be97c0ad7a73cb9

Backport of Core PR16452

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 28 2020, 00:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 00:07
majcosta requested review of this revision.May 28 2020, 00:07
teamcity edited the summary of this revision. (Show Details)May 28 2020, 00:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 28 2020, 00:07

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 28 2020, 00:07

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 28 2020, 00:07

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 28 2020, 00:09

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 28 2020, 00:10

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 28 2020, 00:20

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11057: Diff 20656.May 28 2020, 00:20
nakihito added a subscriber: nakihito.May 28 2020, 00:41

Not sure what D6262 has to do with this patch?

majcosta added a child revision: D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.May 28 2020, 01:05
majcosta edited the summary of this revision. (Show Details)May 28 2020, 02:09
Fabien accepted this revision.May 28 2020, 08:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.h
132 ↗(On Diff #20656)

const TxId &txid

This revision is now accepted and ready to land.May 28 2020, 08:16
Closed by commit rABCac6a10c8b69a: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhyMay 28 2020, 14:10
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCac6a10c8b69a: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Revision Contents
Changeset List

PathSize
src/
interfaces/
5 lines
3 lines
12 lines
node/
4 lines

Diff 20669

View Options

src/interfaces/chain.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/node/transaction.cpp

Loading...