Page MenuHomePhabricator

[backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion
ClosedPublic

Authored by majcosta on May 26 2020, 20:07.

Details

Summary

-BEGIN VERIFY SCRIPT-
git grep -l LockAnnotation | xargs sed -i 's/LockAnnotation/LockAssertion/'
-END VERIFY SCRIPT-

https://github.com/bitcoin/bitcoin/pull/16034/commits/9f85e9cb3d687862128ddf464d2bc2462b8627f0


Depends on D6261

Concludes backport of Core PR16034

Test Plan
cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DENABLE_WERROR=ON -DENABLE_SANITIZERS=thread
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 26 2020, 20:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 20:07
majcosta requested review of this revision.May 26 2020, 20:07
teamcity edited the summary of this revision. (Show Details)May 26 2020, 20:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 27 2020, 11:51
deadalnix added a subscriber: deadalnix.

The test plan is not apropriate

This revision now requires changes to proceed.May 27 2020, 11:51
majcosta requested review of this revision.May 27 2020, 19:30
majcosta edited the test plan for this revision. (Show Details)
majcosta edited the test plan for this revision. (Show Details)

expanded test plan

deadalnix accepted this revision.May 28 2020, 12:28
This revision is now accepted and ready to land.May 28 2020, 12:28