Page MenuHomePhabricator
Differential D6262

[backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion
ClosedPublic
Actions

Authored by majcosta on May 26 2020, 20:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1250f70c3737: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion
Summary

-BEGIN VERIFY SCRIPT-
git grep -l LockAnnotation | xargs sed -i 's/LockAnnotation/LockAssertion/'
-END VERIFY SCRIPT-

https://github.com/bitcoin/bitcoin/pull/16034/commits/9f85e9cb3d687862128ddf464d2bc2462b8627f0

Depends on D6261

Concludes backport of Core PR16034

Test Plan
cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DENABLE_WERROR=ON -DENABLE_SANITIZERS=thread
ninja check-all

Diff Detail

Event Timeline

majcosta created this revision.May 26 2020, 20:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 20:07
majcosta requested review of this revision.May 26 2020, 20:07
teamcity edited the summary of this revision. (Show Details)May 26 2020, 20:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 26 2020, 20:08

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 20:08

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 20:08

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 20:11

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 20:13

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 20:20

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11040: Diff 20627.May 26 2020, 20:20
deadalnix requested changes to this revision.May 27 2020, 11:51
deadalnix added a subscriber: deadalnix.

The test plan is not apropriate

This revision now requires changes to proceed.May 27 2020, 11:51
majcosta requested review of this revision.May 27 2020, 19:30
majcosta edited the test plan for this revision. (Show Details)
majcosta edited the test plan for this revision. (Show Details)

expanded test plan

majcosta added a child revision: D6271: [backport#15492] [rpc] remove deprecated generate method.May 27 2020, 23:11
majcosta added a child revision: D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.May 28 2020, 00:07
nakihito mentioned this in D6271: [backport#15492] [rpc] remove deprecated generate method.May 28 2020, 00:34
nakihito mentioned this in D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.May 28 2020, 00:41
deadalnix accepted this revision.May 28 2020, 12:28
This revision is now accepted and ready to land.May 28 2020, 12:28
Closed by commit rABC1250f70c3737: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion (authored by majcosta). · Explain WhyMay 28 2020, 14:01
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC1250f70c3737: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion.

Revision Contents
Changeset List

PathSize
src/
interfaces/
26 lines
qt/
test/
2 lines
6 lines
wallet/
test/
10 lines

Diff 20627

View Options

src/interfaces/chain.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/sync.h

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...