Page MenuHomePhabricator

[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency
ClosedPublic

Authored by majcosta on May 26 2020, 12:18.

Details

Summary

This ensures wallet code doesn't access node global state, avoiding bugs like
https://github.com/bitcoin/bitcoin/pull/15557#discussion_r267735431


https://github.com/bitcoin/bitcoin/pull/15639/commits/78a2fb55c97fbc26f7b74c5b1fb999a2aff8ce88


Depends on D6255

Concludes backport of Core PR15639

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 26 2020, 12:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 12:18
majcosta requested review of this revision.May 26 2020, 12:18
teamcity edited the summary of this revision. (Show Details)May 26 2020, 12:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the summary of this revision. (Show Details)May 26 2020, 21:53
deadalnix accepted this revision.May 27 2020, 11:41
This revision is now accepted and ready to land.May 27 2020, 11:41