Page MenuHomePhabricator
Differential D6256

[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency
ClosedPublic
Actions

Authored by majcosta on May 26 2020, 12:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCa7a55fb3ac4f: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency
Summary

This ensures wallet code doesn't access node global state, avoiding bugs like
https://github.com/bitcoin/bitcoin/pull/15557#discussion_r267735431

https://github.com/bitcoin/bitcoin/pull/15639/commits/78a2fb55c97fbc26f7b74c5b1fb999a2aff8ce88

Depends on D6255

Concludes backport of Core PR15639

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 26 2020, 12:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2020, 12:18
majcosta requested review of this revision.May 26 2020, 12:18
teamcity edited the summary of this revision. (Show Details)May 26 2020, 12:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 26 2020, 12:19

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 12:20

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 12:21

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 12:22

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 12:23

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 12:29

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11027: Diff 20611.May 26 2020, 12:29
majcosta added a child revision: D6257: [backport#15670] refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight.May 26 2020, 13:08
majcosta updated this revision to Diff 20621.May 26 2020, 18:06

rebase

teamcity added a comment.May 26 2020, 18:07

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 26 2020, 18:07

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 26 2020, 18:07

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 26 2020, 18:08

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 26 2020, 18:11

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 26 2020, 18:17

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11034: Diff 20621.May 26 2020, 18:18
majcosta edited the summary of this revision. (Show Details)May 26 2020, 21:53
deadalnix accepted this revision.May 27 2020, 11:41
This revision is now accepted and ready to land.May 27 2020, 11:41
Closed by commit rABCa7a55fb3ac4f: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyMay 27 2020, 14:16
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa7a55fb3ac4f: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
majcosta added a reverting change: D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".May 27 2020, 17:00
majcosta added a child revision: D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".May 27 2020, 17:15
majcosta added a reverting change: rABC3c12bc770217: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a….May 27 2020, 18:44
majcosta mentioned this in D6789: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.Jun 30 2020, 21:20
majcosta mentioned this in rABCe3f3596aeccb: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.Jun 30 2020, 22:41

Revision Contents
Changeset List

PathSize
src/
2 lines
1 line
wallet/
2 lines

Diff 20636

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/wallet/CMakeLists.txt

Loading...