Differential D6233

[backport#15639] bitcoin-wallet tool: Drop MakeChain calls
ClosedPublic
Actions

Authored by majcosta on May 22 2020, 21:32.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCae40c8eaf22d: [backport#15639] bitcoin-wallet tool: Drop MakeChain calls

Summary

Pass null Chain interface pointer to CWallet. This is needed to drop
libbitcoin_server dependency and avoid linking node code.

https://github.com/bitcoin/bitcoin/pull/15639/commits/fbc6bb8e8310ddf12e675d698cda3bdae4f361b8

Partial backport of Core PR15639

Test Plan

ninja check-all
ninja src/bench/bitcoin-bench
./src/bench/bitcoin-bench -filter=CoinSelection

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 22 2020, 21:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 21:32

majcosta requested review of this revision.May 22 2020, 21:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10993: Diff 20548.May 22 2020, 21:50

deadalnix accepted this revision.May 22 2020, 22:16

This revision is now accepted and ready to land.May 22 2020, 22:16

Closed by commit rABCae40c8eaf22d: [backport#15639] bitcoin-wallet tool: Drop MakeChain calls (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyMay 22 2020, 23:01

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCae40c8eaf22d: [backport#15639] bitcoin-wallet tool: Drop MakeChain calls.

majcosta added a child revision: D6255: [backport#15639] Remove access to node globals from wallet-linked code.May 26 2020, 12:03

Revision Contents
Changeset List

Path

Size

src/

bench/

coin_selection.cpp

4 lines

qt/

test/

addressbooktests.cpp

2 lines

wallettests.cpp

2 lines

wallet/

test/

coinselector_tests.cpp

4 lines

wallet_test_fixture.cpp

5 lines

32 lines

2 lines

9 lines

7 lines

7 lines

Diff 20555

View Options

src/bench/coin_selection.cpp

View Options

src/qt/test/addressbooktests.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/wallet/test/coinselector_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/test/walletdb_tests.cpp

View Options

src/wallet/wallet.h

View Options

src/wallet/wallet.cpp

View Options

[backport#15639] bitcoin-wallet tool: Drop MakeChain callsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20555

src/bench/coin_selection.cpp

src/qt/test/addressbooktests.cpp

src/qt/test/wallettests.cpp

src/wallet/test/coinselector_tests.cpp

src/wallet/test/wallet_test_fixture.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/test/walletdb_tests.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

src/wallet/wallettool.cpp

[backport#15639] bitcoin-wallet tool: Drop MakeChain calls
ClosedPublic
Actions

Revision Contents
Changeset List