Page MenuHomePhabricator

[backport#15639] bitcoin-wallet tool: Drop MakeChain calls
ClosedPublic

Authored by majcosta on May 22 2020, 21:32.

Details

Summary

Pass null Chain interface pointer to CWallet. This is needed to drop
libbitcoin_server dependency and avoid linking node code.

https://github.com/bitcoin/bitcoin/pull/15639/commits/fbc6bb8e8310ddf12e675d698cda3bdae4f361b8


Partial backport of Core PR15639

Test Plan
ninja check-all
ninja src/bench/bitcoin-bench
./src/bench/bitcoin-bench -filter=CoinSelection

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 22 2020, 22:16