Page MenuHomePhabricator

[backport#15639] bitcoin-wallet tool: Drop MakeChain calls
ClosedPublic

Authored by majcosta on May 22 2020, 21:32.

Details

Summary

Pass null Chain interface pointer to CWallet. This is needed to drop
libbitcoin_server dependency and avoid linking node code.

https://github.com/bitcoin/bitcoin/pull/15639/commits/fbc6bb8e8310ddf12e675d698cda3bdae4f361b8


Partial backport of Core PR15639

Test Plan
ninja check-all
ninja src/bench/bitcoin-bench
./src/bench/bitcoin-bench -filter=CoinSelection

Event Timeline

majcosta created this revision.May 22 2020, 21:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 21:32
majcosta requested review of this revision.May 22 2020, 21:32
teamcity edited the summary of this revision. (Show Details)May 22 2020, 21:32

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.May 22 2020, 22:16
This revision is now accepted and ready to land.May 22 2020, 22:16