HomePhabricator

[backport#15670] refactor: combine Chain…

Description

[backport#15670] refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight

Summary:
As suggested in #14711, pass height to CChain::FindEarliestAtLeast to
simplify Chain interface by combining findFirstBlockWithTime and
findFirstBlockWithTimeAndHeight into one

Extend findearliestatleast_edge_test in consequence


https://github.com/bitcoin/bitcoin/pull/15670/commits/765c0b364d41e9a251c3f88cbe203645854fd790

Depends on D6256

Backport of Core PR15670

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6257

Details

Provenance
Antoine Riard <ariard@student.42.fr>Authored on Mar 26 2019, 16:46
majcostaCommitted on May 27 2020, 14:49
majcostaPushed on May 27 2020, 14:49
Reviewer
Restricted Project
Differential Revision
D6257: [backport#15670] refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
Parents
rABCa7a55fb3ac4f: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency
Branches
Unknown
Tags
Unknown