HomePhabricator

gui: Add NAT-PMP network option

Description

gui: Add NAT-PMP network option

Summary:
Also add release notes for -natpmp and mention the command line option in tor.md.

This concludes backport of core#18077 [10 & 13/13]
https://github.com/bitcoin/bitcoin/pull/18077/commits/5a0185b6c9c838290103314916190a0330ed9a82
https://github.com/bitcoin/bitcoin/pull/18077/commits/a191e23b8e7f0e19fc0359825eb7ca0d47966fa9

Depends on D12095

Test Plan:
ninja && src/qt/bitcoin-qt

In the menu Settings > Options > Network, check for a new checkbox "Map port using NAT-PMP". Verify that this setting is persistent accross shutdown and restart.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12096

Details

Provenance
Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>Authored on Feb 23 2020, 00:25
PiRKCommitted on Sep 30 2022, 09:58
PiRKPushed on Sep 30 2022, 09:58
Reviewer
Restricted Project
Differential Revision
D12096: gui: Add NAT-PMP network option
Parents
rABCa5c67b8aa9ae: net: Add -natpmp command line option
Branches
Unknown
Tags
Unknown

Event Timeline

PiRK committed rABC0b909244f606: gui: Add NAT-PMP network option (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).Sep 30 2022, 09:58