Page MenuHomePhabricator
Differential D12096

gui: Add NAT-PMP network option
ClosedPublic
Actions

Authored by PiRK on Sep 29 2022, 14:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0b909244f606: gui: Add NAT-PMP network option
Summary

Also add release notes for -natpmp and mention the command line option in tor.md.

This concludes backport of core#18077 [10 & 13/13]
https://github.com/bitcoin/bitcoin/pull/18077/commits/5a0185b6c9c838290103314916190a0330ed9a82
https://github.com/bitcoin/bitcoin/pull/18077/commits/a191e23b8e7f0e19fc0359825eb7ca0d47966fa9

Depends on D12095

Test Plan

ninja && src/qt/bitcoin-qt

In the menu Settings > Options > Network, check for a new checkbox "Map port using NAT-PMP". Verify that this setting is persistent accross shutdown and restart.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 29 2022, 14:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2022, 14:19
PiRK requested review of this revision.Sep 29 2022, 14:19
teamcity edited the summary of this revision. (Show Details)Sep 29 2022, 14:19
PiRK updated this revision to Diff 35292.Sep 29 2022, 14:32
PiRK edited the summary of this revision. (Show Details)

squash release notes with feature completion commit

Harbormaster completed remote builds in B20247: Diff 35290.Sep 29 2022, 14:39
Harbormaster completed remote builds in B20249: Diff 35292.Sep 29 2022, 15:03
Fabien requested changes to this revision.Sep 29 2022, 15:10
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
21–22 ↗(On Diff #35292)
src/qt/forms/optionsdialog.ui
265 ↗(On Diff #35292)
This revision now requires changes to proceed.Sep 29 2022, 15:10
PiRK updated this revision to Diff 35302.Sep 29 2022, 16:01

feedback

Harbormaster completed remote builds in B20258: Diff 35302.Sep 29 2022, 16:10
teamcity added a comment.Sep 29 2022, 16:10
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien accepted this revision.Sep 30 2022, 07:52
This revision is now accepted and ready to land.Sep 30 2022, 07:52
This revision was landed with ongoing or failed builds.Sep 30 2022, 09:58
Closed by commit rABC0b909244f606: gui: Add NAT-PMP network option (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0b909244f606: gui: Add NAT-PMP network option.

Revision Contents
Changeset List

PathSize
doc/
11 lines
2 lines
src/
qt/
forms/
10 lines
4 lines

Diff 35317

View Options

doc/release-notes.md

Loading...
View Options

doc/tor.md

Loading...
View Options

src/qt/forms/optionsdialog.ui

Loading...
View Options

src/qt/optionsdialog.cpp

Loading...