Page MenuHomePhabricator
Differential D12094

QA: Run tests with UPnP disabled
ClosedPublic
Actions

Authored by PiRK on Sep 29 2022, 10:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe94de8a0b664: QA: Run tests with UPnP disabled
Summary

This is a backport of core#16646

Depends on D12093

Test Plan
cmake .. -GNinja -DSTART_WITH_UPNP=ON
ninja && ninja check-functional

rm -Rf *
cmake .. -GNinja -DENABLE_UPNP=OFF
ninja && ninja check-functional

Note that I did not manage to produce a test failure, with or without this change. So the test just shows that no problem is introduced.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 29 2022, 10:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2022, 10:31
PiRK requested review of this revision.Sep 29 2022, 10:31
teamcity edited the summary of this revision. (Show Details)Sep 29 2022, 10:31
PiRK edited the summary of this revision. (Show Details)Sep 29 2022, 10:32
PiRK added a parent revision: D12093: [qa] Avoid printing to console during cache creation.
Harbormaster completed remote builds in B20240: Diff 35280.Sep 29 2022, 10:46
PiRK updated this revision to Diff 35282.Sep 29 2022, 11:39

rebase

PiRK added a child revision: D12075: net: Add libnatpmp support.Sep 29 2022, 11:42
Harbormaster completed remote builds in B20241: Diff 35282.Sep 29 2022, 12:14
Fabien accepted this revision.Sep 29 2022, 12:47
This revision is now accepted and ready to land.Sep 29 2022, 12:47
Closed by commit rABCe94de8a0b664: QA: Run tests with UPnP disabled (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by PiRK). · Explain WhySep 29 2022, 13:11
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe94de8a0b664: QA: Run tests with UPnP disabled.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
1 line

Diff 35288

View Options

test/functional/test_framework/util.py

Loading...