HomePhabricator

bugfix: make LoadWallet assigns status always

Description

bugfix: make LoadWallet assigns status always

Summary:
Although loadwallet() in rpcwallet.cpp assumes LoadWallet() always
assign some value to the 'status', but LoadWallet() does not do so
in some situation.

This fixes above and prevends loadwallet() returns ambiguous error code.

This is a backport of core#19919

The problem is probably introduced in D10227 or D10229, but I wasn't able to reproduce
it.

Depends on D10231

Test Plan:

ninja
for i in $(seq 20); do test/functional/test_runner.py wallet_multiwallet; done

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10240

Details

Provenance
Akio Nakamura <nakamura@dgtechnologies.co.jp>Authored on Sep 8 2020, 16:11
PiRKCommitted on Oct 5 2021, 08:47
PiRKPushed on Oct 5 2021, 08:47
Reviewer
Restricted Project
Differential Revision
D10240: bugfix: make LoadWallet assigns status always
Parents
rABC5dc21608b9dd: wallet: Remove path checking code from bitcoin-wallet tool
Branches
Unknown
Tags
Unknown