Page MenuHomePhabricator
Differential D10229

wallet: Remove path checking code from loadwallet RPC
ClosedPublic
Actions

Authored by PiRK on Sep 30 2021, 13:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC18aeb323c584: wallet: Remove path checking code from loadwallet RPC
Summary

This commit does not change behavior except for error messages which now
include more complete information.

This is a backport of core#19619 [6/8]
https://github.com/bitcoin/bitcoin/pull/19619/commits/a987438e9d9cad0b5530e218a447928485f3fd93

Depends on D10228
Depends on D10213 (for rpc_createmultisig.py)

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 30 2021, 13:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2021, 13:42
PiRK requested review of this revision.Sep 30 2021, 13:42
teamcity edited the summary of this revision. (Show Details)Sep 30 2021, 13:42
PiRK added a child revision: D10230: wallet: Remove path checking code from createwallet RPC.Sep 30 2021, 13:44
Harbormaster completed remote builds in B16835: Diff 30239.Sep 30 2021, 14:14
PiRK mentioned this in D10240: bugfix: make LoadWallet assigns status always.Oct 1 2021, 06:32
Fabien accepted this revision.Oct 1 2021, 09:03
This revision is now accepted and ready to land.Oct 1 2021, 09:03
PiRK edited the summary of this revision. (Show Details)Oct 4 2021, 06:15
PiRK added a parent revision: D10213: Add a --descriptors option to various tests.
Closed by commit rABC18aeb323c584: wallet: Remove path checking code from loadwallet RPC (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyOct 5 2021, 08:50
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC18aeb323c584: wallet: Remove path checking code from loadwallet RPC.
PiRK mentioned this in rABC0ddd20024bf7: bugfix: make LoadWallet assigns status always.

Revision Contents
Changeset List

PathSize
src/
wallet/
24 lines
test/
functional/
8 lines
18 lines

Diff 30310

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/rpc_createmultisig.py

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...