Page MenuHomePhabricator

wallet: Add MakeDatabase function
ClosedPublic

Authored by PiRK on Sep 30 2021, 13:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9c7a754d5935: wallet: Add MakeDatabase function
Summary

New function is not currently called but will be called in upcoming commits. It
moves database path checking, and existence checking, and already-loaded
checking, and verification into a single function so this logic does not need
to be repeated all over higher level wallet code, and so higher level code does
not need to change when SQLite support is added in
https://github.com/bitcoin/bitcoin/pull/19077. This also lets higher level
wallet code make fewer assumptions about the contents of wallet directories.

This commit just adds the new function and does not change behavior in any way.

This is a backport of core#19619 [2/8]
https://github.com/bitcoin/bitcoin/pull/19619/commits/b5b414151af32e5a07b5757b64482d77519d77c0

Depends on D10224

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable