Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC407828747f4d: Remove the automatic creation and loading of the default wallet

Summary

No longer create a default wallet. The default wallet will still be
loaded if it exists and not other wallets were specified (anywhere,
including settings.json, bitcoin.conf, and command line).

Tests are updated to be started with -wallet= if they need the default
wallet.

Added test to wallet_startup.py testing that no default wallet is
created and that it is loaded if it exists and no other wallets were
specified.

Tell users how to load or create a wallet when no wallet is loaded

This is a backport of core#15454 and core#19971 (bug fix)

Depends on D10240

Test Plan

ninja all check check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 1 2021, 14:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2021, 14:41

PiRK requested review of this revision.Oct 1 2021, 14:41

teamcity edited the summary of this revision. (Show Details)Oct 1 2021, 14:41

PiRK edited the summary of this revision. (Show Details)Oct 1 2021, 14:41

PiRK added a parent revision: D10240: bugfix: make LoadWallet assigns status always.

PiRK added a child revision: D10244: Tell users how to load or create a wallet when no wallet is loaded.Oct 1 2021, 14:44

put comment on its own line

Harbormaster completed remote builds in B16860: Diff 30274.Oct 1 2021, 14:51

Harbormaster completed remote builds in B16862: Diff 30276.Oct 1 2021, 15:00

Please run the extended functional tests as part of the test plan

doc/release-notes.md
19 ↗	(On Diff #30276)	I don't see this in the diff (nor in the original commit), is there a PR missing ?

This revision now requires changes to proceed.Oct 2 2021, 11:13

Fabien mentioned this in D10244: Tell users how to load or create a wallet when no wallet is loaded.Oct 2 2021, 11:16

In D10243#230389, @Fabien wrote:

Please run the extended functional tests as part of the test plan

Well spotted. I need to squash with https://github.com/bitcoin/bitcoin/pull/19971

Squash the two commits for core#15454 so that the release note does not refer to a future feature in the first one.
Squash with core#19971 to fix also extended tests.
Update description accordingly (test plan +extended, backport +PR19971)

put the comment back on its own line (rebase regression in previous change)

Harbormaster completed remote builds in B16871: Diff 30288.Oct 4 2021, 12:20

Harbormaster completed remote builds in B16872: Diff 30289.Oct 4 2021, 12:27

Fabien accepted this revision.Oct 4 2021, 18:59

This revision is now accepted and ready to land.Oct 4 2021, 18:59

PiRK retitled this revision from Do not create default wallet to Remove the automatic creation and loading of the default wallet.Oct 6 2021, 13:51

rebase for release notes

Harbormaster completed remote builds in B16914: Diff 30352.Oct 6 2021, 17:11

Closed by commit rABC407828747f4d: Remove the automatic creation and loading of the default wallet (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyOct 7 2021, 05:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC407828747f4d: Remove the automatic creation and loading of the default wallet.

Remove the automatic creation and loading of the default wallet
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 30360

doc/release-notes/release-notes.md

src/interfaces/wallet.h

src/interfaces/wallet.cpp

src/qt/bitcoingui.h

src/qt/bitcoingui.cpp

src/qt/walletframe.cpp

src/wallet/init.cpp

src/wallet/load.h

src/wallet/load.cpp

src/wallet/test/init_test_fixture.cpp

src/wallet/test/wallet_test_fixture.h

test/functional/feature_dbcrash.py

test/functional/feature_filelock.py

test/functional/feature_pruning.py

test/functional/wallet_backup.py

test/functional/wallet_dump.py

test/functional/wallet_import_rescan.py

test/functional/wallet_multiwallet.py

test/functional/wallet_startup.py

Remove the automatic creation and loading of the default walletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30360

doc/release-notes/release-notes.md

src/interfaces/wallet.h

src/interfaces/wallet.cpp

src/qt/bitcoingui.h

src/qt/bitcoingui.cpp

src/qt/walletframe.cpp

src/wallet/init.cpp

src/wallet/load.h

src/wallet/load.cpp

src/wallet/test/init_test_fixture.cpp

src/wallet/test/wallet_test_fixture.h

test/functional/feature_dbcrash.py

test/functional/feature_filelock.py

test/functional/feature_pruning.py

test/functional/wallet_backup.py

test/functional/wallet_dump.py

test/functional/wallet_import_rescan.py

test/functional/wallet_multiwallet.py

test/functional/wallet_startup.py

Remove the automatic creation and loading of the default wallet
ClosedPublic
Actions

Revision Contents
Changeset List