Page MenuHomePhabricator

Remove the automatic creation and loading of the default wallet
ClosedPublic

Authored by PiRK on Fri, Oct 1, 14:41.

Details

Summary

No longer create a default wallet. The default wallet will still be
loaded if it exists and not other wallets were specified (anywhere,
including settings.json, bitcoin.conf, and command line).

Tests are updated to be started with -wallet= if they need the default
wallet.

Added test to wallet_startup.py testing that no default wallet is
created and that it is loaded if it exists and no other wallets were
specified.

Tell users how to load or create a wallet when no wallet is loaded

This is a backport of core#15454 and core#19971 (bug fix)

Depends on D10240

Test Plan

ninja all check check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Fri, Oct 1, 14:41

put comment on its own line

Fabien requested changes to this revision.Sat, Oct 2, 11:13
Fabien added a subscriber: Fabien.

Please run the extended functional tests as part of the test plan

doc/release-notes.md
19 ↗(On Diff #30276)

I don't see this in the diff (nor in the original commit), is there a PR missing ?

This revision now requires changes to proceed.Sat, Oct 2, 11:13

Please run the extended functional tests as part of the test plan

Well spotted. I need to squash with https://github.com/bitcoin/bitcoin/pull/19971

PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

Squash the two commits for core#15454 so that the release note does not refer to a future feature in the first one.
Squash with core#19971 to fix also extended tests.
Update description accordingly (test plan +extended, backport +PR19971)

put the comment back on its own line (rebase regression in previous change)

This revision is now accepted and ready to land.Mon, Oct 4, 18:59
PiRK retitled this revision from Do not create default wallet to Remove the automatic creation and loading of the default wallet.Wed, Oct 6, 13:51

rebase for release notes