HomePhabricator

[backport#16911] wallet: Only check the hash of transactions loaded from disk

Description

[backport#16911] wallet: Only check the hash of transactions loaded from disk

Summary:
Only check the hash of transactions loaded from disk (Andrew Chow)

Pull request description:

It feels unnecessary to do a full `CheckTransaction` for every transaction saved in the wallet. It should not be possible for an invalid transaction to get into the wallet in the first place, and if there is any disk corruption, the hash check will catch it.

Backport of Core PR16911

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7386

Details

Provenance
Wladimir J. van der Laan <laanwj@protonmail.com>Authored on Oct 23 2019, 10:03
majcostaCommitted on Sep 8 2020, 13:59
majcostaPushed on Sep 8 2020, 13:59
Reviewer
Restricted Project
Differential Revision
D7386: [backport#16911] wallet: Only check the hash of transactions loaded from disk
Parents
rABC39f861a08167: [backport#16689 2/2] Add missing fields in TransactionDescriptionString and…
Branches
Unknown
Tags
Unknown