Differential D7386

[backport#16911] wallet: Only check the hash of transactions loaded from disk
ClosedPublic
Actions

Authored by majcosta on Sep 7 2020, 21:35.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC0df084c088ab: [backport#16911] wallet: Only check the hash of transactions loaded from disk

Summary

Only check the hash of transactions loaded from disk (Andrew Chow)

Pull request description:

It feels unnecessary to do a full `CheckTransaction` for every transaction saved in the wallet. It should not be possible for an invalid transaction to get into the wallet in the first place, and if there is any disk corruption, the hash check will catch it.

Backport of Core PR16911

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 7 2020, 21:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2020, 21:35

majcosta requested review of this revision.Sep 7 2020, 21:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12654: Diff 23356.Sep 7 2020, 21:45

Fabien accepted this revision.Sep 8 2020, 06:10

This revision is now accepted and ready to land.Sep 8 2020, 06:10

Closed by commit rABC0df084c088ab: [backport#16911] wallet: Only check the hash of transactions loaded from disk (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhySep 8 2020, 13:59

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC0df084c088ab: [backport#16911] wallet: Only check the hash of transactions loaded from disk.

Revision Contents
Changeset List

Path

Size

src/

wallet/

8 lines

Diff 23369

src/wallet/walletdb.cpp

Loading...