Page MenuHomePhabricator

[backport#16911] wallet: Only check the hash of transactions loaded from disk
ClosedPublic

Authored by majcosta on Sep 7 2020, 21:35.

Details

Summary

Only check the hash of transactions loaded from disk (Andrew Chow)

Pull request description:

It feels unnecessary to do a full `CheckTransaction` for every transaction saved in the wallet. It should not be possible for an invalid transaction to get into the wallet in the first place, and if there is any disk corruption, the hash check will catch it.

Backport of Core PR16911

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta requested review of this revision.Sep 7 2020, 21:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Sep 8 2020, 06:10